-
-
Notifications
You must be signed in to change notification settings - Fork 93
[ADD][runbot_buildout] improvements #199
[ADD][runbot_buildout] improvements #199
Conversation
8888a54
to
f081cef
Compare
14c5424
to
4015fdd
Compare
4015fdd
to
186cee6
Compare
I believe the complaints from codepatch are a fluke, it shows at least some file from runbot_docker as the one not being tested enough, and this isn't in the diff here... after merging this, I think we can rebase #197 and then this should come back green too |
186cee6
to
9eb2207
Compare
9eb2207
to
b3b4513
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot minor |
Hi @moylop260. Your command failed:
Ocabot commands
More information
|
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
it can't be merged by ocabot since that there is a unrelated error then merging manually |
thanks @moylop260 Question: Therp uses the pre-docker branch of runbot in v11 because she never did the step to container stuff. Are you still busy with this in v11, or are you using the v13 runbot and do reviews here as a courtesy (in that case, thank you so much)? |
We are using pre-docker too. |
buildout_default
on builds, but set a default buildout on the repo. The original was meant to support multiple versions in the same repo, but this turns out awkward and usually you only temporarily have two versions. This you can deal with with branch specific buildout branches then.