Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_report_salesperson_from_partner: Migration to 16.0 #296

Merged

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Nov 29, 2024

cc @Tecnativa TT51908

@carlosdauden @sergio-teruel please review

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor change ;)

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_report_salesperson_from_partner branch from 4c10c74 to 150a098 Compare December 2, 2024 06:46
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_report_salesperson_from_partner branch from 150a098 to a7545fd Compare December 4, 2024 15:27
@pilarvargas-tecnativa
Copy link
Author

@sergio-teruel Removed also in migration

@sergio-teruel
Copy link
Contributor

Fix tests... Thanks

@rousseldenis
Copy link
Contributor

/ocabot migration sale_report_salesperson_from_partner

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_report_salesperson_from_partner branch 2 times, most recently from 11c190c to 39be952 Compare December 5, 2024 08:39
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_report_salesperson_from_partner branch from 39be952 to 4ad630d Compare December 5, 2024 08:45
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-sale_report_salesperson_from_partner branch from 4ad630d to a7f5e53 Compare December 5, 2024 09:59
@pilarvargas-tecnativa
Copy link
Author

Fix tests... Thanks

Solved!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-296-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1c916b9 into OCA:16.0 Dec 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 81bf760. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_report_salesperson_from_partner branch December 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants