Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] sale_stock_prebook: Add process to prebook a sale order's stock #2624

Open
wants to merge 5 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][ADD] sale_stock_prebook: Add process to prebook a sale order's stock #2624

wants to merge 5 commits into from

Conversation

mt-software-de
Copy link

@mt-software-de mt-software-de commented Jul 28, 2023 •
edited
Loading

Add process to prebook/reserve a sale order's stock before confirming it.

Depends on
OCA/stock-logistics-warehouse#1807 NOT NEEDED ANYMORE
OCA/wms#769 MERGED

@mt-software-de mt-software-de mentioned this pull request Jul 28, 2023
Closed
@mt-software-de
Copy link
Author

cc @jbaudoux

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from eeb0523 to 1dd3f52 Compare July 28, 2023 13:36
@rousseldenis
Copy link
Contributor

@mt-software-de What's the difference with stock_reserve_sale ?

OCA/stock-logistics-warehouse#1788

@mt-software-de
Copy link
Author

mt-software-de commented Jul 29, 2023 •
edited
Loading

@mt-software-de What's the difference with stock_reserve_sale ?

OCA/stock-logistics-warehouse#1788

Please read the comment of @jbaudoux OCA/stock-logistics-warehouse#1696 (comment)
This explains it very well.

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from 1dd3f52 to 0566ab0 Compare July 31, 2023 23:16
@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 2 times, most recently from 4d44c8f to 45daaa6 Compare October 30, 2023 11:15
@mt-software-de
Copy link
Author

OCA/wms#769 is needed for this PR.

jbaudoux
jbaudoux approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Oct 30, 2023 •
edited
Loading

OCA/wms#769 is needed for this PR.

Can you update this PR description with this?

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 4 times, most recently from 3574259 to 1b4c64a Compare November 10, 2023 00:27
@rafaelbn rafaelbn added this to the 14.0 milestone Dec 2, 2023
rafaelbn
rafaelbn approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested 👍🏼

In my opinion README with the USAGE section should be improved with all how to / step by step. In other case, less reviewer, less user adopting it. 😄 ❤️

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 5 times, most recently from cb6d552 to b58aec8 Compare June 2, 2024 11:10
@mt-software-de
Copy link
Author

This one is now ready to merge, i removed the dependency to stock_helper and included the very specific logic to stop the proc run, within the module itself.

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from b58aec8 to d9d0d79 Compare June 2, 2024 11:28
@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from d9d0d79 to 1c2c026 Compare October 17, 2024 13:54
lmignon
lmignon suggested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to process the picking generated for the reservation. It should not be possible to set quantity done on the move line nor to validate the picking.

@jbaudoux
Copy link
Contributor

It's possible to process the picking generated for the reservation. It should not be possible to set quantity done on the move line nor to validate the picking.

This line https://github.com/OCA/sale-workflow/pull/2624/files#diff-2a79dc3628d7cbd98f204791750fadc712f3e43c11341eabb2c722c7157eb258R12 should prevent it. How come you made the move ready ?

This was referenced Nov 25, 2024
Draft
Open
@rousseldenis
Copy link
Contributor

@mt-software-de @jbaudoux What's ths status of this ?

@mt-software-de
Copy link
Author

@mt-software-de @jbaudoux What's ths status of this ?

Sorry i was not working on this.
I still need to check why the test are failing. On my dev env they are green.

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 2 times, most recently from 9a9c1cf to 7822a9d Compare February 5, 2025 19:40
@mt-software-de
Copy link
Author

mt-software-de commented Feb 5, 2025 •
edited
Loading

@mt-software-de @jbaudoux What's ths status of this ?

I found the error.
Its again a module which changes the default odoo behavior. sale_cancel_confirm.
I changed the github test flow.
0b3da45

Besides that this one is ready to merge.
This is already quite sometime in production

@mt-software-de
Copy link
Author

It's possible to process the picking generated for the reservation. It should not be possible to set quantity done on the move line nor to validate the picking.

This line https://github.com/OCA/sale-workflow/pull/2624/files#diff-2a79dc3628d7cbd98f204791750fadc712f3e43c11341eabb2c722c7157eb258R12 should prevent it. How come you made the move ready ?

ping @lmignon

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from 7822a9d to aae739c Compare February 5, 2025 19:59
@mt-software-de
Fix Testing sale.order action_cancel
0b3da45 
By default sale_cancel_confirm overwrites the method
When there is a addon which is doing something afterwards
this results in an error in testing
@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from aae739c to e6ea5d4 Compare February 5, 2025 20:30
@lmignon
Copy link
Contributor

lmignon commented Feb 6, 2025

I've just made a request for a new repo to group together the addons relating to stock pre-booking. see OCA/repo-maintainer-conf#73

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 2 times, most recently from 52e4e86 to 4912165 Compare February 7, 2025 09:29
mt-software-de and others added 3 commits February 7, 2025 10:36
@mt-software-de
[ADD] sale_stock_prebook: Add process to prebook a sale order's stock…
377ec74 
… before confirming it
@mt-software-de
[ADD] sale_stock_prebook_stock_available_to_promise_release:
af037f9 
Take moves into account when computing the previous promised qty
Keep date_priority of Confirmed sale.orders which were reserved before
@lmignon @mt-software-de
[IMP] sale_stock_prebook: Do not allow to set quantity done
57f3768 
on reserved stock moves
@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch from 4912165 to 57f3768 Compare February 7, 2025 09:41
@mt-software-de
Copy link
Author

@lmignon @yostashiro i added your suggestions.

@lmignon i added a separate commit, with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved help wanted needs fixing needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mt-software-de @rousseldenis @jbaudoux @lmignon @OCA-git-bot @rafaelbn @dreispt