[16.0][FIX] sale_exception_holidays_public: tests don't pass #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jbaudoux, |
EmilioPascual
changed the title
chienandalu
reviewed
Dec 22, 2023
chienandalu
reviewed
Dec 22, 2023
EmilioPascual
force-pushed
the
fix-sale_exception_holidays_public
branch
from
5f2ff53 to
47c6e7c
Compare
chienandalu
reviewed
Dec 22, 2023
yajo
approved these changes
Dec 22, 2023
rafaelbn
changed the title
|
Please @leemannd @simahawk @santostelmo this test are making all PR in OCA will fails until 1st january! 😲 Could you please review? |
|
Add the suggested change #2868 (comment) and then it can be merged |
we have been bad and they bring us coal 😢 |
Before, if there are less than 10 days left to the end of the year, tests don't pass MT-4381
EmilioPascual
force-pushed
the
fix-sale_exception_holidays_public
branch
from
47c6e7c to
6d3af99
Compare
It's the Grinch of datetime issues spoiling our CIs on christmas season 😁 |
HaraldPanten
approved these changes
Dec 22, 2023
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 37c8f7c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if there are less than 10 days left to the end of the year, tests don't pass
MT-4381