-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] stock_quant_manual_assign: Correct handling of immediate transfers #2038
Conversation
This PR supersedes #1908 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code and Functional Reviews)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functioanl and code review.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Seems great
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This commit fixes the following issues: - The previous code does not handle the immediate transfer scenario when auto_fill_qty_done is selected in the operation type. This raises a missing-record error, trying to update qty_done on non-existing move line records. - move._do_unreserve() keeps existing stock.move.line records if there is some qty_done set, which is not a desirable outcome. All the linked move line records should be unlinked before selected quants are assigned.
0151b24
to
c7dc47b
Compare
@oca/stock-logistics-warehouse-maintainers |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at b94a8a1. Thanks a lot for contributing to OCA. ❤️ |
This commit fixes the following issues:
auto_fill_qty_done
is selected in the operation type. This raises a missing-record error, trying to updateqty_done
on non-existing move line records.move._do_unreserve()
keeps existing stock.move.line records if there is someqty_done
set, which is not a desirable outcome. All the linked move line records should be unlinked before selected quants are assigned.I also took the liberty of refactoring the test code a bit.
@qrtl QT4574