Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] New module 'website_google_tag_manager' #278

Merged
merged 4 commits into from
Dec 19, 2016
Merged

[ADD] New module 'website_google_tag_manager' #278

merged 4 commits into from
Dec 19, 2016

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Nov 14, 2016 •
edited
Loading

Google Tag Manager

This module allows to configure your Odoo website to support the Google Tag Manager tool.

Configuration

To configure this module, you need to:

  • go to Website Admin/Configuration
  • fill in your Google Tag Manager Key (e.g. GTM-ABCDEF)

@lasley
Copy link
Contributor

lasley commented Nov 25, 2016 •
edited
Loading

@sebalix - a rebase on current base should fix your Travis

@sebalix sebalix force-pushed the 9.0-website_google_tag_manager branch from 51dbc9d to 47c4620 Compare November 29, 2016 10:10
@sebalix
Copy link
Contributor Author

sebalix commented Nov 29, 2016

@lasley thanks, Travis and runbot are now green

@lasley lasley added this to the 9.0 milestone Nov 29, 2016
lasley
lasley approved these changes Nov 30, 2016
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sebalix - minor comment but otherwise 👍

website_google_tag_manager/views/templates.xml
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2016 ABF OSIELL <http://osiell.com>
License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
<openerp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<odoo> and can remove data tags (in all files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lasley done

@rafaelbn
Copy link
Member

Hi @sebalix thanks for this module. When you make a PR please paste in the description of the PR de description of the module, this helps a lot to get the interest in your PR because when you receive the email you can read what if the module for 😉

@sebalix
Copy link
Contributor Author

sebalix commented Dec 1, 2016 •
edited
Loading

@rafaelbn I'm used to do so, I just forgot it ;) Updated.

susport
susport reviewed Dec 19, 2016
View reviewed changes
Copy link

@susport susport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lasley lasley merged commit 743e455 into OCA:9.0 Dec 19, 2016
@lasley
Copy link
Contributor

lasley commented Dec 19, 2016

Thanks @sebalix

cristinamartinrod pushed a commit to Tecnativa/website that referenced this pull request Oct 11, 2018
@sebalix @cristinamartinrod
[ADD] New module 'website_google_tag_manager' (OCA#278)
48b9395 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
HviorForgeFlow pushed a commit to ForgeFlow/website that referenced this pull request Oct 25, 2018
@sebalix @HviorForgeFlow
[ADD] New module 'website_google_tag_manager' (OCA#278)
63535be 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
@sebalix sebalix deleted the 9.0-website_google_tag_manager branch October 30, 2018 10:15
cristinamartinrod pushed a commit to Tecnativa/website that referenced this pull request Dec 20, 2018
@sebalix @cristinamartinrod
[ADD] New module 'website_google_tag_manager' (OCA#278)
568f72d 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
cristinamartinrod pushed a commit to Tecnativa/website that referenced this pull request Feb 26, 2019
@sebalix @cristinamartinrod
[ADD] New module 'website_google_tag_manager' (OCA#278)
60fbbb9 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
bjornbillen pushed a commit to bjornbillen/website that referenced this pull request Jan 15, 2020
@sebalix @bjornbillen
[ADD] New module 'website_google_tag_manager' (OCA#278)
cd072f0 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
bjornbillen pushed a commit to bjornbillen/website that referenced this pull request Jan 31, 2020
@sebalix @bjornbillen
[ADD] New module 'website_google_tag_manager' (OCA#278)
6e6f5ef 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SimoneVagile pushed a commit to SimoneVagile/website that referenced this pull request Nov 5, 2020
@sebalix @SimoneVagile
[ADD] New module 'website_google_tag_manager' (OCA#278)
ce6a276 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
fshah-initos pushed a commit to initOS/website that referenced this pull request Nov 11, 2020
@sebalix @foramaktiv
[ADD] New module 'website_google_tag_manager' (OCA#278)
e052d5f 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SimoneVagile pushed a commit to SimoneVagile/website that referenced this pull request Nov 12, 2020
@sebalix @SimoneVagile
[ADD] New module 'website_google_tag_manager' (OCA#278)
a709118 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SimoneVagile pushed a commit to SimoneVagile/website that referenced this pull request Sep 29, 2021
@sebalix @SimoneVagile
[ADD] New module 'website_google_tag_manager' (OCA#278)
401c267 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SimoneVagile pushed a commit to SimoneVagile/website that referenced this pull request Oct 20, 2021
@sebalix @SimoneVagile
[ADD] New module 'website_google_tag_manager' (OCA#278)
58f1827 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
JrAdhoc pushed a commit to adhoc-dev/oca-website that referenced this pull request Jun 23, 2022
@sebalix @JrAdhoc
[ADD] New module 'website_google_tag_manager' (OCA#278)
e11d4d9 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
matiasperalta1 pushed a commit to adhoc-dev/oca-website that referenced this pull request Nov 23, 2022
@sebalix @matiasperalta1
[ADD] New module 'website_google_tag_manager' (OCA#278)
616aae7 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
bvanjeelharia pushed a commit to bvanjeelharia/website that referenced this pull request Dec 19, 2022
@sebalix @bvanjeelharia
[ADD] New module 'website_google_tag_manager' (OCA#278)
394f1e7 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SodexisTeam pushed a commit to sodexis/website that referenced this pull request Nov 23, 2023
@sebalix
[ADD] New module 'website_google_tag_manager' (OCA#278)
74b005e 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
JrAdhoc pushed a commit to adhoc-dev/oca-website that referenced this pull request Oct 18, 2024
@sebalix @jr2-adhoc
[ADD] New module 'website_google_tag_manager' (OCA#278)
844b4f1 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
SodexisTeam pushed a commit to sodexis/website that referenced this pull request Dec 24, 2024
@sebalix
[ADD] New module 'website_google_tag_manager' (OCA#278)
77c664a 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
amkarthik pushed a commit to sodexis/website that referenced this pull request Feb 4, 2025
@sebalix @amkarthik
[ADD] New module 'website_google_tag_manager' (OCA#278)
5b81f3a 
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susport susport susport left review comments

@lasley lasley lasley approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sebalix @lasley @rafaelbn @susport