15.0 mig website legal page #875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix review comments - Icon changed - Bug tracker added - [IMP] README and OCA as author [FIX] Space at the end of a traslation line [FIX] mailto links in default legal pages is malformed
Many submodules from this one need the template I'm adding. Having it here allows for better reusability and avoids duplicated translation efforts.
* Move legal pages to explicit /legal routes Fixes by PR review Fix my obvious lack of testing
- Update copyright headers. - Update copyright holders data. - Remove .pot file. - Add migration script.
* [ADD][website_multi_theme] Allow different themes by website This a somewhat hacky addon that adds support for setting a different theme by website. Always updates views arch in development and demo instances. This allows faster development, while keeping stability and no surprises in production. * fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * squash! fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found Fix tests that were getting warnings logged and random timeouts.
[FIX] Linter on website_multi_theme py file
Fix OCA#415 now that odoo/odoo#22438 has been fixed upstream.
[FIX] website_legal_page: Fix PO
Currently translated at 100,0% (49 of 49 strings) Translation: website-11.0/website-11.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_legal_page/de/
Currently translated at 91,8% (45 of 49 strings) Translation: website-11.0/website-11.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_legal_page/es/
Currently translated at 91,8% (45 of 49 strings) Translation: website-11.0/website-11.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_legal_page/es/
IMP website_legal_page with CSS classes to ease styling FIX README
[FIX] website_legal_page: update view names
Currently translated at 100.0% (49 of 49 strings) Translation: website-12.0/website-12.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_legal_page/pt_BR/
Currently translated at 100.0% (35 of 35 strings) Translation: website-14.0/website-14.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_legal_page/es_AR/
Currently translated at 7.8% (4 of 51 strings) Translation: website-14.0/website-14.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_legal_page/ca/
Currently translated at 100.0% (51 of 51 strings) Translation: website-14.0/website-14.0-website_legal_page Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_legal_page/it/
| from odoo import SUPERUSER_ID, api | ||
|
|
||
|
|
||
| def _merge_views(env, xmlids): |
There was a problem hiding this comment.
Any chance we can have some unit tests for this method?
If you don't have the time, don't worry about it..
tarteo
requested changes
Mar 11, 2022
|
|
||
|
|
||
| class WebsiteLegalPage(http.Controller): | ||
| @http.route(["/shop/terms"], type="http", auth="public", website=True) |
There was a problem hiding this comment.
In 15.0 this is /terms not /shop/terms
|
Functional review 👍 PR name should be: [MIG] website_legal_page: Migration to 15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.