Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] website_cookiefirst: Migration to 15.0 #892

Merged
merged 6 commits into from
Aug 10, 2022
Merged

[MIG] website_cookiefirst: Migration to 15.0 #892

merged 6 commits into from
Aug 10, 2022

Conversation

ioans73
Copy link
Member

@ioans73 ioans73 commented May 17, 2022

Standard migration to 15.0

@ferran-S73 ferran-S73 force-pushed the 15.0-mig_website_cookiefirst branch from e10398c to b531faf Compare May 17, 2022 16:42
@gregory-moka
Copy link

Hi @fuentes73, what is blocking on this PR ?

@fuentes73
Copy link
Member

Hi @gregory-moka more approves are needed.
If you tested de module please approve and the OCA-git-bot will label this PR "ready to merge".

@miguel-S73
Copy link
Contributor

LGTM

tarteo
tarteo approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I couldn't test the functionality because I dont have a Cookiefirst ID'

gregory-moka
gregory-moka reviewed Aug 10, 2022
View reviewed changes
Copy link

@gregory-moka gregory-moka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine from CookieFirst to Odoo : banner & cookie policies are well implemented.
I don't understand the way a script has to be configured.
For example, Google Analytics :

  • Its configured on CookieFisrt side
  • Should we disable GA from Odoo side ?

If we do so, the GA script doesn't seems to be loader even if its allowed by visitor. It's a bit complicated for me 🤔

@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration website_cookiefirst

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 10, 2022
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-892-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 10, 2022
Closed
12 tasks
@OCA-git-bot OCA-git-bot merged commit bdb4ca6 into OCA:15.0 Aug 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 299be7d. Thanks a lot for contributing to OCA. ❤️

@miguel-S73 miguel-S73 deleted the 15.0-mig_website_cookiefirst branch August 10, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-moka gregory-moka gregory-moka left review comments

@miguel-S73 miguel-S73 miguel-S73 approved these changes

@tarteo tarteo tarteo approved these changes

@fuentes73 fuentes73 fuentes73 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ioans73 @gregory-moka @fuentes73 @miguel-S73 @pedrobaeza @OCA-git-bot @tarteo @oca-travis @ferran-S73