[15.0][MIG] website_cookiebot: Migration to version 15.0 #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganize templates. - Make templates noupdate=0, because if user edits them, it will be in the COW'd, website-specific version, so no problem on that. - Rename `cookiebot_id` to `cookiebot_dgid` to avoid confusion with X2many fields. - Remove ICP support, as the DGID should be per website. - Add ID placeholders to Cookie Declaration page editable sections. - Ensure Google Analytic script is blocked before consenting statistics. FTR it wasn't actually being blocked. - Improve instructions. - Split README. - Apply pre-commit. @Tecnativa TT32828
chienandalu
suggested changes
Jan 3, 2023
Comment on lines
5
to
14
| <template id="layout_footer_copyright" inherit_id="web.frontend_layout"> | ||
| <xpath | ||
| expr="//body" | ||
| position="inside" | ||
| > | ||
| <div> | ||
| <span t-if="website.cookiebot_dgid">- <a | ||
| href="/legal/cookies-policy" | ||
| >Cookies Policy</a></span> | ||
| </div> | ||
|
|
||
| </xpath> | ||
| </template> |
There was a problem hiding this comment.
Check this other module implementation that will give you a clue on how to make it better (inherit from that other template): https://github.com/OCA/website/blob/14.0/website_legal_page/views/website_legal_main_page.xml#L4-L18
stefan-tecnativa
force-pushed
the
15.0-mig-website_cookiebot
branch
from
afd69a1 to
dfb4de7
Compare
|
/ocabot migration website_cookiebot |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6e22930. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT39017
@chienandalu @pedrobaeza please review!