Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] website_snippet_big_button: Migration to version 15.0 #940

Merged
merged 18 commits into from
Jan 17, 2023

Conversation

pilarvargas-tecnativa
Copy link

cc @Tecnativa TT41033

@chienandalu @CarlosRoca13 please review

Jairo Llopis and others added 18 commits January 17, 2023 09:07
- Delete CSS source.
- Use new snippets & snippet options API.
- New JS API.
- Follow guidelines and put templates under `templates/`
- LGPL.
- Remove usage of CSS grid. Too new for some browsers.
- Use flexbox instead to allow full responsiveness.
- Do not use block elements inside inline ones. Use classes `d-block` and `h3` instead.
- Fix wrapping issue.
- Do not use readable class; now it gets close to the same results giving more flexibility to the user.
Currently translated at 0.0% (0 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/fr/
Without this patch, a big button with a lot of content will fail to
render properly in phones.
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/pt_BR/
Currently translated at 50.0% (1 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/hr/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/sl/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/ca/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/fr/
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-mig-website_snippet_big_button branch from c11aa92 to b5bce23 Compare January 17, 2023 08:39
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

If you feel creative you could change the icon using https://ivantodorovich.github.io/odoo-icon/

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot migration website_snippet_big_button
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 17, 2023
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-940-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2023
12 tasks
@OCA-git-bot OCA-git-bot merged commit fe85251 into OCA:15.0 Jan 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba0c38a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.