Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 0001-digest-algorithms.md with parameters #10

Closed
wants to merge 1 commit into from
Closed

Update 0001-digest-algorithms.md with parameters #10

wants to merge 1 commit into from

Conversation

neilsjefferies
Copy link
Member

Updated digest extension to include parameters

@neilsjefferies
Update 0001-digest-algorithms.md
56f2ffa 
Updated digest extension to include parameters
zimeon
zimeon previously approved these changes May 19, 2020
View reviewed changes
@zimeon zimeon mentioned this pull request May 19, 2020
Closed
awoods
awoods reviewed May 22, 2020
View reviewed changes
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me that the "digest algorithms" extension needs to be parameterized. My understanding was that any algorithms mentioned in the table of this extension are fair-game for use in the OCFL structures, period.

Base automatically changed from Parameterised-extensions-definition to master June 2, 2020 13:16
@rosy1280
Copy link
Contributor

rosy1280 commented Jun 9, 2020

at the 2020.06.02 Editors meeting we agreed that this doesn't need to be parameterized. Closing without merging seems to be the next course of action....

@zimeon zimeon self-requested a review June 9, 2020 21:39
@zimeon zimeon dismissed their stale review June 9, 2020 21:40

Change of mind after discussion about whether parameterization needed

@neilsjefferies
Copy link
Member Author

Drop parameterization for this as per 20200602 Editors Meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoods awoods awoods left review comments

@ahankinson ahankinson Awaiting requested review from ahankinson

@julianmorley julianmorley Awaiting requested review from julianmorley

@rosy1280 rosy1280 Awaiting requested review from rosy1280

@zimeon zimeon Awaiting requested review from zimeon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neilsjefferies @rosy1280 @awoods @zimeon