Add missing 1.0 spec examples #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeon
requested review from
rosy1280,
awoods,
julianmorley,
neilsjefferies and
srerickson
rosy1280
previously approved these changes
Nov 7, 2024
neilsjefferies
previously approved these changes
Nov 7, 2024
srerickson
reviewed
Nov 7, 2024
There was a problem hiding this comment.
validating this fixture results in a warning because v1 is missing a message (edit: and user). Given that this is based on an example from the spec, I wonder if it's worth updating the example to include a message. Otherwise, should this fixture be moved warn-objects?
There was a problem hiding this comment.
I agree, moved:
./ocfl-validate.py fixtures/1.0/warn-objects/W007_spec-ex-diff-paths
[W007a] OCFL Object root inventory v1 version block SHOULD include a message key (see https://ocfl.io/1.0/spec/#W007)
[W007b] OCFL Object root inventory v1 version block SHOULD include a user key (see https://ocfl.io/1.0/spec/#W007)
OCFL v1.0 Object at fixtures/1.0/warn-objects/W007_spec-ex-diff-paths is VALID
|
Thanks @srerickson ! Have moved both into |
rosy1280
approved these changes
Dec 5, 2024
neilsjefferies
approved these changes
Dec 5, 2024
julianmorley
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have spec-ex-full but not other examples in the 1.0 spec. This PR adds the first and third examples.