correct zero-padded max version calculation

OCFL · Jan 28, 2022 · bcc7254 · bcc7254
1 parent b924517
commit bcc7254
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/ocfl-java-api/src/main/java/edu/wisc/library/ocfl/api/model/VersionNum.java b/ocfl-java-api/src/main/java/edu/wisc/library/ocfl/api/model/VersionNum.java
@@ -107,7 +107,7 @@ public VersionNum(long versionNumber, int zeroPaddingWidth) {
         if (zeroPaddingWidth == 0) {
             maxVersion = Long.MAX_VALUE;
         } else {
-            maxVersion = (10 * (zeroPaddingWidth - 1)) - 1;
+            maxVersion = (long) Math.pow(10, zeroPaddingWidth - 1) - 1;
         }
     }
 

diff --git a/ocfl-java-api/src/test/java/edu/wisc/library/ocfl/api/model/VersionNumTest.java b/ocfl-java-api/src/test/java/edu/wisc/library/ocfl/api/model/VersionNumTest.java
@@ -40,10 +40,10 @@ public void shouldIncrementVersionWhenNoPadding() {
 
     @Test
     public void shouldIncrementVersionWhenHasPadding() {
-        var versionNum = VersionNum.fromString("v03");
+        var versionNum = VersionNum.fromString("v00039");
         var nextVersion = versionNum.nextVersionNum();
-        assertEquals("v03", versionNum.toString());
-        assertEquals("v04", nextVersion.toString());
+        assertEquals("v00039", versionNum.toString());
+        assertEquals("v00040", nextVersion.toString());
     }
 
     @Test
@@ -70,7 +70,7 @@ public void shouldFailDecrementWhenPreviousVersion0() {
 
     @Test
     public void shouldFailIncrementWhenNextVersionIsIllegalPaddedNumber() {
-        var versionNum = VersionNum.fromString("v09");
+        var versionNum = VersionNum.fromString("v09999");
         assertThrows(InvalidVersionException.class, versionNum::nextVersionNum);
     }