Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E092. #444

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Add E092. #444

merged 1 commit into from
Apr 10, 2020

Conversation

julianmorley
Copy link
Contributor

Tiny tweak to add a validation error that was missed in the initial pass.

@julianmorley julianmorley requested a review from zimeon April 7, 2020 21:42
@zimeon
Copy link
Contributor

zimeon commented Apr 7, 2020

Well spotted! I wonder whether we would best best to restructure the first sentence to include the name of the file in the MUST for E058, otherwise that MUST will be basically meaningless/uncheckable. We could say:

Every occurrence of an inventory file [E058]MUST have an accompanying sidecar file named inventory.json.ALGORITHM stating its digest, where ALGORITHM is the chosen digest algorithm for the object. The ALGORITHM [E059]MUST match the value given for the digestAlgorithm key in the inventory. An example might be inventory.json.sha512.

Copy link
Contributor

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created #448 to debate change to remove this MUST but agree change proposed here is correct given the current text

@zimeon zimeon merged commit 3e086d8 into master Apr 10, 2020
@zimeon zimeon deleted the RFC2119 branch April 10, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants