Update index.html etc. for #540 - Empty version directories must have inventories #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Validation Error code
Added text for E109
Amended text to match Error message
neilsjefferies
changed the title
neilsjefferies
requested review from
awoods,
zimeon,
julianmorley,
rosy1280 and
a team
rosy1280
previously approved these changes
Oct 19, 2021
julianmorley
previously approved these changes
Oct 19, 2021
zimeon
requested changes
Oct 21, 2021
|
There appear to be merge conflicts on this branch. |
neilsjefferies
dismissed stale reviews from julianmorley and rosy1280
via
0196524
rosy1280
reviewed
Nov 10, 2021
| <code>inventory.json</code> in version directories, the inventory file in the OCFL Object Root | ||
| <span id="E064">MUST</span> be the same as the file in the most recent version. See also requirements for | ||
| the corresponding <a href="#inventory-digest">Inventory Digest</a>. | ||
| all content for versions up to and including that particular version. In the case where no files have been |
There was a problem hiding this comment.
I think we could make this cleaner by starting a new paragraph at
In the case where.....
But I'm not going to hold up approval for that simple change.
rosy1280
approved these changes
Nov 10, 2021
|
Cover this in version directory description instead (also allow .keep rather than forcing an inventory) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.