-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In a file, "ODM2PythonAPI/ODM2/models.py" #1
Comments
Great! Two problems below were found. |
another one was found. |
@cdesyoun I've made all of these changes except changing the Boolean to a Bit. Could you explain why you would like this change. BIT is db specific, and we are trying to keep the api generic across the b types. are you having errors when running with Boolean? |
@sreeder No, I meant changing the type in "Specimens" class below from "BIT" type to "Boolean" type in ODM2PythonAPI. class Specimens(Base):
|
@sreeder, I imported this api into ODM2 Web service, and tested it. In addition, class CVReferenceMaterialMedium(Base):
After this, please correct it as follows: I have made an change all of these things in my github below: If you are OK, you can replace it with this. |
Would you please fix these problems below?
-- please fix the spelling error (ResultDateTimeUTCOfffset ==> ResultDateTimeUTCOffset)
-- please add the "cv_relationshiptype" class
class CVRelationshipType(Base):
tablename = 'cv_relationshiptype'
table_args = {u'schema': 'odm2'}
-- plead add the type, "Integer" in the class "SamplingFeatureExternalIdentifiers".
"BridgeID = Column('bridgeid', Integer, primary_key=True, nullable=False)"
-- please replace "BIT" type with "Boolean" type in the class "Specimens".
"IsFieldSpecimen = Column('isfieldspecimen', Boolean, nullable=False)"
The text was updated successfully, but these errors were encountered: