Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev1_0 branch ready for merging into master? #50

Closed
emiliom opened this issue Apr 11, 2016 · 6 comments
Closed

Dev1_0 branch ready for merging into master? #50

emiliom opened this issue Apr 11, 2016 · 6 comments

Comments

@emiliom
Copy link
Member

emiliom commented Apr 11, 2016

@sreeder, is the Dev1_0 ready for merging into master? Or are you planning to do more testing? Would be great to have it merged by the end of the week. We can then issue a new odm2api release and update the conda package. Thanks!

@emiliom
Copy link
Member Author

emiliom commented Apr 15, 2016

With PR #51 now merged into Dev1_0 (thanks!!), is Dev1_0 ready for merging into master?

Before or after that merge we could also move forward with #38 by removing the ODM1_1_1 stuff, now that @sreeder has preserved it in the odm1dev branch.

@sreeder
Copy link
Contributor

sreeder commented Apr 15, 2016

@emiliom I am working on merging Dev1_0 now, but it will break all of the testing stuff so I am pulling the code from master into my branch, fixing the tests, then merging it back into master.

@emiliom
Copy link
Member Author

emiliom commented Apr 15, 2016

Got it, thanks.

@sreeder
Copy link
Contributor

sreeder commented Apr 15, 2016

@emiliom I have started removing ODM1 in the removeODM1 Branch. I still have some things to fix but should be able to get that done by Monday as well.

@emiliom
Copy link
Member Author

emiliom commented Apr 18, 2016

@sreeder, that's great! I'm really looking forward to this.

sreeder pushed a commit that referenced this issue Apr 22, 2016
@emiliom
Copy link
Member Author

emiliom commented Apr 23, 2016

Merged. Closing.

@emiliom emiliom closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants