Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conda-forge #148

Merged
merged 1 commit into from
Feb 23, 2018
Merged

use conda-forge #148

merged 1 commit into from
Feb 23, 2018

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 22, 2018

@lsetiawan and @emiliom this PR makes use of the conda-forge version of the odm2 packages.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 22, 2018

It looks like the AppVeyor failure here is unrelated to this PR.

@lsetiawan
Copy link
Member

All of these PR should have been committed to the development branch, but oh well, it's done now. I'm gonna pull the latest stuff to development.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2018

All of these PR should have been committed to the development branch, but oh well, it's done now. I'm gonna pull the latest stuff to development.

Sorry for the trouble. It is hard to revert to an exception workflow when working on many other OSS projects that adhere to the standard workflow. But I'll try to remember next time 😬

BTW, maybe the "use-development-branch-as-master" workflow should be documented in the README file to help people outside of the ODM2 circle contribute to the code here.

@lsetiawan
Copy link
Member

lsetiawan commented Feb 26, 2018

Sorry for the trouble.

No worries. I should've checked.

BTW, maybe the "use-development-branch-as-master" workflow should be documented in the
README file to help people outside of the ODM2 circle contribute to the code here.

That's a great idea. Thanks. I'll add that in somewhere.

@ocefpaf The ODM2 Team has been following the Gitflow workflow.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2018

@ocefpaf The ODM2 Team has been following the Gitflow workflow.

Maybe you should just mention that in the README. It is not widely used and more people will trip on this.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2018

PS: http://endoflineblog.com/gitflow-considered-harmful 😸

@lsetiawan
Copy link
Member

Thank you for the article. 😄 Very useful!

@horsburgh
Copy link
Member

And also just one person's opinion. I disagree with the statement that it's not widely used, and so does your blogger (even though he clearly doesn't like it)!

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2018

And also just one person's opinion.

Indeed. That blog was just an example I sent to @lsetiawan.

I disagree with the statement that it's not widely used

It was at the time of the original post and in the web community. Since then it became obscure and the vast majority of the OSS community dropped the gitflow.

However, it is important to note that the best workflow is the one you are used to 😉

ODM2 should only change from gitflow to another community standard if the group wants to reduce the learning curve for newcomers.

@lsetiawan lsetiawan mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants