Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change the visibility of Created and Updated in ODataController to public #2148

Open
henrikdahl8240 opened this issue May 5, 2020 · 2 comments
Assignees
Labels

Comments

@henrikdahl8240
Copy link

In ODataController, can’t you change the visibility of Created and Updated from protected to public?

This will make it much easier to factor out creation and updating to helper classes. You can see, that in ControllerBase, the visibility of OK, BadRequest, NotFound etc. have also been changed from protected to public when changing from .NET Framework to .NET Core. Therefore the change I suggest is in line with general improvements done.

@henrikdahl8240
Copy link
Author

It seems excellent, Sam. Do you see a possibility to also do #2148 for the 7.4.1 release, i.e. to make the two methods Created and Updated in ODataController public instead of protected?

For your information, today I have some helper classes for my ODataController derivates and I must pass a lambda expression for Created and Updated, which I obviously find rather annoying.

If you are interested in having me to try a nightly build, where you have changed the visibility to public, I can easily do that.

@xuzhg
Copy link
Member

xuzhg commented May 8, 2020

@henrikdahl8240 Got it. I will update you if you have news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants