You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In ODataController, can’t you change the visibility of Created and Updated from protected to public?
This will make it much easier to factor out creation and updating to helper classes. You can see, that in ControllerBase, the visibility of OK, BadRequest, NotFound etc. have also been changed from protected to public when changing from .NET Framework to .NET Core. Therefore the change I suggest is in line with general improvements done.
The text was updated successfully, but these errors were encountered:
It seems excellent, Sam. Do you see a possibility to also do #2148 for the 7.4.1 release, i.e. to make the two methods Created and Updated in ODataController public instead of protected?
For your information, today I have some helper classes for my ODataController derivates and I must pass a lambda expression for Created and Updated, which I obviously find rather annoying.
If you are interested in having me to try a nightly build, where you have changed the visibility to public, I can easily do that.
In
ODataController
, can’t you change the visibility ofCreated
andUpdated
fromprotected
topublic
?This will make it much easier to factor out creation and updating to helper classes. You can see, that in
ControllerBase
, the visibility ofOK
,BadRequest
,NotFound
etc. have also been changed fromprotected
topublic
when changing from .NET Framework to .NET Core. Therefore the change I suggest is in line with general improvements done.The text was updated successfully, but these errors were encountered: