Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch dunfell to tegra boot tools #154

Conversation

tirankas
Copy link

These are a collection of commits pulled together to switch the dunfell 32.5.0 branch to use Tegra boot tools instead of the redundant boot.

@madisongh
Copy link
Member

@tirankas could you add a Signed-off-by line to the commit message, as described in our contributing guidelines? I can take care of the necessary newline fixups I mentioned in the discussion thread.

Thanks!

@tirankas
Copy link
Author

Hi @madisongh
I committed the spaces & new lines fixes (removing tabs, fixing indentation and added new lines).
I just now saw your request for signed-off. How do I do that given the commit is made...

@tirankas
Copy link
Author

Hi @madisongh
Is it OK now?

Thanks

@ichergui
Copy link
Member

Hi @madisongh
Is it OK now?

Thanks

Could you please add signed-off-by in this commit and this one ?

Thanks

@madisongh
Copy link
Member

@ichergui I'll take care of fixing that up as part of the merge. There are a few other tweaks needed as well, based on my testing.

@ichergui
Copy link
Member

@ichergui I'll take care of fixing that up as part of the merge. There are a few other tweaks needed as well, based on my testing.

@madisongh
I can do the test as well, I have my Jetson Xavier NX here.
Please let me know if I can help to validate this PR

@tirankas
Copy link
Author

Hi @madisongh
I am not able to sign the other two commits, it gives an error:
error: gpg failed to sign the data
fatal: failed to write commit object

Not sure where this comes from.
I did sign one commit...

Command used is: git commit --amend -S -c 6a582f6

@madisongh
Copy link
Member

@tirankas GPG signing isn't required. All I needed was the Signed-off-by line, which you've already added.

Thanks

@tirankas
Copy link
Author

Great, thanks!
I will verify again on the NX Xavier when my build completed. Will probably need to verify again on the nano. Will post when I am done.

@madisongh
Copy link
Member

I've tested on Nano (SD and eMMC), TX2, and Xavier NX (eMMC), updating dunfell-32.4.3 -> 32.5.x -> 32.6.1. Found one issue in tegra-boot-tools (specific to t210 platforms), and have fixed that.

Nano (SD): 32.4.3->32.5.x fails as expected; 32.5.x -> 32.6.1 OK
All updates for all other succeed as expected.

@madisongh
Copy link
Member

I've manually merged this.

Thanks again, @tirankas !

@madisongh madisongh closed this Sep 20, 2021
@dwalkes
Copy link
Member

dwalkes commented Sep 25, 2021

Thanks @madisongh and @tirankas ! I see this made it into the dunfell branch as well in dbb64a2
So based on previous discussion in OE4T/meta-tegra#798 (reply in thread) I think we are now on tegra-boot-tools for all branches dunfell-l4t-r32.4.3 or later in tegra-demo-distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants