D3D11: _create2DTex() with mSurface. #3273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paroj
reviewed
Jan 15, 2025
paroj
reviewed
Jan 15, 2025
paroj
reviewed
Jan 15, 2025
paroj
reviewed
Jan 15, 2025
paroj
reviewed
Jan 15, 2025
paroj
reviewed
Jan 16, 2025
paroj
reviewed
Jan 16, 2025
| @@ -232,46 +232,106 @@ namespace Ogre | |||
| inline bool IsPowerOfTwo(unsigned int n) { return ((n&(n-1))==0); } | |||
| //--------------------------------------------------------------------- | |||
| void D3D11Texture::_create2DTex() | |||
| { | |||
| if (NULL != mSurface) | |||
There was a problem hiding this comment.
instead of if else around everything I suggest you do:
if(mSurface)
{
_createShared2DTex();
return;
}
paroj
reviewed
Jan 16, 2025
| @@ -625,4 +687,6 @@ namespace Ogre | |||
| { | |||
| rebind(static_cast<D3D11HardwarePixelBuffer*>(mBuffer)); | |||
| } | |||
| } | |||
| //--------------------------------------------------------------------- | |||
| void D3D11RenderTexture::doFlush() { mDevice.Flush(); } | |||
There was a problem hiding this comment.
I suggest you remove this for now. It should be part of RenderSystem as it not only affects this single texture.
Also see my comment on the forums. Maybe we do not need this at all.
paroj
reviewed
Jan 16, 2025
| hr = pUnk->QueryInterface(__uuidof(IDXGIResource), (void**)&pDXGIResource); | ||
| if (FAILED(hr)) | ||
| { | ||
| throw std::runtime_error("Failed to query IDXGIResource interface from the provided object."); |
There was a problem hiding this comment.
please use the OGRE_EXCEPT_EX macro instead of throwing directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a variable called mSurface that can be used to create a texture from an already existing surface. Inside the _create2DTex() function, there is an if statement to check whether this variable exists or not. If it exists, it will be manipulated to be used as an Ogre texture.