Added Achilles container image build #34
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in OHDSI/Achilles#536, this adds a workflow for building Achilles as a container image.
This is done as a preparation for moving the OHDSI stack Helm chart from my private repository over at https://github.com/chgl/charts/tree/master/charts/ohdsi (see #23) to the OHDSI community. Once an official container image for Achilles is available, the one I used for the chart (ghcr.io/chgl/ohdsi/achilles:master) can be replaced and therfore all images can be traced back to OHDSI repositories. The script and Dockerfile is based on OHDSI/Achilles#510 and OHDSI/Achilles#507.
The included workflow will build a new image on every push to master, tagged using that commits SHA, and every time a git tag
achilles-image/v*
is created. Depending on the prefered versioning startegy, this could for example allow tagging new images asv1.0.0-achilles-1.6.3
, or maybe more accurately in its current setup:v1.0.0-achilles-c6b7adb
to reference the current achilles version as well as allowing for independently versioning the image itself.In order for this to work, two secrets will have to be created for the broadsea repository:
DOCKERHUB_USERNAME
andDOCKERHUB_TOKEN
containing a username and DockerHub PAT to push to theohdsi
group respectively; similar to OHDSI/WebAPI#1690.If accepted, I'll prepare a new PR next that will setup the repository to include the Helm chart currently hosted at https://github.com/chgl/charts/tree/master/charts/ohdsi updated to use the new Achilles image.