Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Achilles container image build #34

Closed

Conversation

chgl
Copy link

@chgl chgl commented Mar 11, 2022

As per the discussion in OHDSI/Achilles#536, this adds a workflow for building Achilles as a container image.

This is done as a preparation for moving the OHDSI stack Helm chart from my private repository over at https://github.com/chgl/charts/tree/master/charts/ohdsi (see #23) to the OHDSI community. Once an official container image for Achilles is available, the one I used for the chart (ghcr.io/chgl/ohdsi/achilles:master) can be replaced and therfore all images can be traced back to OHDSI repositories. The script and Dockerfile is based on OHDSI/Achilles#510 and OHDSI/Achilles#507.

The included workflow will build a new image on every push to master, tagged using that commits SHA, and every time a git tag achilles-image/v* is created. Depending on the prefered versioning startegy, this could for example allow tagging new images as v1.0.0-achilles-1.6.3, or maybe more accurately in its current setup: v1.0.0-achilles-c6b7adb to reference the current achilles version as well as allowing for independently versioning the image itself.

In order for this to work, two secrets will have to be created for the broadsea repository: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN containing a username and DockerHub PAT to push to the ohdsi group respectively; similar to OHDSI/WebAPI#1690.

If accepted, I'll prepare a new PR next that will setup the repository to include the Helm chart currently hosted at https://github.com/chgl/charts/tree/master/charts/ohdsi updated to use the new Achilles image.

@chgl chgl force-pushed the added-build-for-achilles-container-image branch 2 times, most recently from 15f1799 to 19a0c32 Compare March 13, 2022 16:13
@chgl chgl force-pushed the added-build-for-achilles-container-image branch from 19a0c32 to b740578 Compare March 13, 2022 20:10
@leeevans
Copy link
Contributor

@chgl thanks for creating the Achilles container!

The approach I've used for Broadsea is that each application container has it's own github repo and the container name is prefixed with 'broadsea':

OHDSI/broadsea-webtools
OHDSI/broadsea-methodslibrary

This Broadsea github repo just refers to the containers maintained in those application container github repos.

If you are OK with making the container name 'ohdsi/broadsea-achilles' I can request a new OHDSI github repo called OHDSI/broadsea-achilles?

When the new broadsea-achilles github repo is available, if you can create a new PR there, I can go ahead and approve it.

@t-abdul-basser
Copy link

t-abdul-basser commented Mar 16, 2022

@chgl @leeevans Is the plan to the OHDSI Helm chart to this OHDSI repo, Broadsea, or to another repo?

@chgl
Copy link
Author

chgl commented Mar 16, 2022

Thank you @leeevans, a ohdsi/broadsea-achilles repo sounds great! I'll rename the container accordingly and move the PR over there.

@t-abdul-basser Good question, I don't think we've found a consent in #23 yet. If the intention behind "broadsea" is to house anything related to containers, then it seems fitting (although the helm chart doesn't yet include the R methods library mentioned in the repo description). Personally, I think a OHDSI/charts or OHDSI/helm-charts might be a bit more explicit - but does add to repository "sprawl".

@leeevans
Copy link
Contributor

leeevans commented Mar 29, 2022

@chgl ohdsi/Broadsea-Achilles is now available. Please feel free to re-submit the pull request there.

@t-abdul-basser Yes, I think it's a good idea for "broadsea" to be a place to maintain official OHDSI community containers. We can keep helm-charts in the OHDSI/Broadsea gitHub repo under a "helm-charts" sub-dir if that would be helpful.

@leeevans
Copy link
Contributor

@chgl and @t-abdul-basser The following new OHDSI Broadsea GitHub repos are also now available.

OHDSI/Broadsea-Dqd
OHDSI/Broadsea-Cdminspection
OHDSI/Broadsea-solr

@leeevans leeevans closed this Mar 29, 2022
@chgl chgl deleted the added-build-for-achilles-container-image branch May 11, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants