Vocabulary search common classes #56
Merged
+108
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to a separate library OHDSI/WebAPI#2201 Based on the idea OHDSI/WebAPI#2196 Referencing the latest Standardized Analysis Utils and Circe 1.5.0 release preparation
chrisknoll
requested changes
Sep 11, 2023
pom.xml
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <groupId>org.ohdsi</groupId> | |||
| <artifactId>standardized-analysis-specs</artifactId> | |||
| <version>1.4.0</version> | |||
| <version>1.5.0</version> | |||
There was a problem hiding this comment.
This should be -SNAPSHOT for our dev branch. We remove the -SNAPSHOT for release.
| "CONCEPT_CODE", "DOMAIN_ID", "VOCABULARY_ID", "CONCEPT_CLASS_ID", | ||
| "VALID_START_DATE", "VALID_END_DATE" | ||
| }) | ||
| public class Concept extends org.ohdsi.circe.vocabulary.Concept { |
There was a problem hiding this comment.
This is something that feels messy now: That the StandardAnalysisAPI is pulling a base class from another library (circe) but then extending it here in SAA to add ValidStartDate/ValidEndDate.
I don't think we need to take action now, but ideally what we should have in the future is that we can define standard objects in SAA (such as Concept) and haave circe-be depend back on SAA to get the 'standard' classes (along with defining it's own cohort specific classes). Eventually, it would be nice to have the circe classes put into SAA (but that is much much further down the road).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To proceed with the search in Vocabularies using Apache Solr extraction to a separate library OHDSI/WebAPI#2201
Based on the idea OHDSI/WebAPI#2196 Referencing the latest Standardized Analysis Utils and Circe 1.5.0 release preparation