Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to get feature analysis data(ConversionFailedException) #1758

Closed
DKashenko opened this issue Jan 25, 2021 · 1 comment · Fixed by #1763 or #1786
Closed

Failed to get feature analysis data(ConversionFailedException) #1758

DKashenko opened this issue Jan 25, 2021 · 1 comment · Fixed by #1763 or #1786
Assignees
Labels
Milestone

Comments

@DKashenko
Copy link

DKashenko commented Jan 25, 2021

WebApi 2.8.1 (in 2.8 it works fine)

Steps:

  1. Login by admin
  2. Characterizations -> Feature Analysis
  3. Try to open any analysis

Actual:
Loader CC

WebAPI/feature-analysis
Request Method: GET
Status Code: 500

{"payload":{"cause":null,"stackTrace":[],"message":"An exception occurred: org.springframework.core.convert.ConversionFailedException","localizedMessage":"An exception occurred: org.springframework.core.convert.ConversionFailedException","suppressed":[]},"headers":{"id":"7c8e257e-0e5b-8cd3-4559-df9b7eff8518","timestamp":1611571544778}}

2021-01-25 10:35:07.328 ERROR http-nio-8080-exec-4 org.ohdsi.webapi.util.GenericExceptionMapper -  - org.springframework.core.convert.ConversionFailedException: Failed to convert from type [org.ohdsi.webapi.feanalysis.domain.FeAnalysisWithPrevalenceCriteriaEntity] to type [org.ohdsi.webapi.feanalysis.dto.FeAnalysisDTO] for value 'org.ohdsi.webapi.feanalysis.domain.FeAnalysisWithPrevalenceCriteriaEntity@d0'; nested exception is org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: org.ohdsi.webapi.feanalysis.domain.FeAnalysisWithCriteriaEntity.design, could not initialize proxy - no Session
	at org.springframework.core.convert.support.ConversionUtils.invokeConverter(ConversionUtils.java:44)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:203)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:187)
	at org.ohdsi.webapi.feanalysis.FeAnalysisController.convertFeAnalysisToDto(FeAnalysisController.java:227)
	at org.ohdsi.webapi.feanalysis.FeAnalysisController.getFeAnalysis(FeAnalysisController.java:125)
	at org.ohdsi.webapi.feanalysis.FeAnalysisController$$FastClassBySpringCGLIB$$a67f86b9.invoke(<generated>)
	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:667)
	at org.ohdsi.webapi.feanalysis.FeAnalysisController$$EnhancerBySpringCGLIB$$80cb8f85.getFeAnalysis(<generated>)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
	at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
	at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
	at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$TypeOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:205)
	at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:99)
	at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:389)
	at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:347)
@KSadomtsev KSadomtsev changed the title Loader gets stuck when we trying to open Feature Analysis Failed to get feature analysis data(ConversionFailedException) Jan 25, 2021
@KSadomtsev KSadomtsev added the bug label Jan 25, 2021
@KSadomtsev KSadomtsev added this to the V2.8.1 milestone Jan 25, 2021
anton-abushkevich pushed a commit that referenced this issue Jan 29, 2021
@KSadomtsev KSadomtsev reopened this Feb 16, 2021
@KSadomtsev
Copy link

@ssuvorov-fls reproduced again on <hibernate.version>5.4.18

ssuvorov-fls added a commit that referenced this issue Feb 16, 2021
chrisknoll pushed a commit that referenced this issue Feb 16, 2021
fixes #1758

Co-authored-by: Sergey Suvorov <[email protected]>
# Conflicts:
#	pom.xml
chrisknoll pushed a commit that referenced this issue Feb 16, 2021
chrisknoll pushed a commit that referenced this issue Feb 16, 2021
…nly in 5.4.2.Final version of hibernate(#1758)

# Conflicts:
#	pom.xml
anton-abushkevich added a commit that referenced this issue Feb 17, 2021
* prepare for release 2.8.0

* 2.8.1-SNAPSHOT

* Update CIRCE to 1.9.1

(cherry picked from commit 9fac161)

* Remove trailing ; from DELETE (#1752)

Fixes #1730.

(cherry picked from commit 66f9100)

* PLP/PLE Analysis result file missed analysis executable code #1729 (#1751)

* removed tomcat dependency from hive profile (#1748)

changed default runtime delegate
(#1720)

Co-authored-by: Sergey Suvorov <[email protected]>

* Issue 1733 build error without git dir (#1757)

* git-commit-id-plugin does not throw exception in case of absent .git folder
if git_commit-id-plugin can not get git info parameters then gmaven-plugin creates these parameters with default value ("*")
(#1733)

* removed temporary dependencies
(#1733)

Co-authored-by: Sergey Suvorov <[email protected]>

* Update org.apache.httpcomponents:httpclient version from 4.5.10 to 4.5.13 (#1747)

* eager loading is now used during conversion of entities to dto (#1763)

fixes #1758

Co-authored-by: Sergey Suvorov <[email protected]>
# Conflicts:
#	pom.xml

* GitHub actions (#1690)

* Puts Maven Central as the first repository

This speeds up the build A LOT when none of the dependencies have been
cached yet (e.g. when performing a docker build). Reason: without putting this repository first, all
dependencies are first searched in all of the specified repositories and
only afterwards the central repository is tried. Because most
dependencies are not present in the specified repositories, still
central needs to be queried afterwards. When putting the central
repository first, this reduces time to retrieve dependencies in two
ways:

1. The central repository has a very low latency, much lower than the
other repositories. If a dependency can be fetched from here, it will be
faster than when it is fetched from another one.
2. For most dependencies, it reduces the number of repositories queried
from 7 to 1.

* Enabled github actions

* Use dedicated docker profile to avoid long command line

* Backport github action fixes

* Fix typo

* Remove unsupported platform

* Only use Maven central in the webapi-docker profile

* ancestorAndDescendant:get permission is now added to new sources  (#1766)

* ancestorAndDescendant:get permission is now added to new sources
fixes #1759

* ancestorAndDescendant:get permission is now added to new sources
fixes #1759

* fixed identation
fixes #1759

* ancestorAndDescendant:get permission is not added to new sources #1759 - fix permission name

Co-authored-by: Sergey Suvorov <[email protected]>
Co-authored-by: Anton Abushkevich <[email protected]>

* ir generation results are now exported correctly (#1767)

queryForRowSet function calls isSigned function which is not implemented for hive
fixes #1765

Co-authored-by: Sergey Suvorov <[email protected]>

* Fix sql server migration.
Revert a721214.
Remove IF EXISTS from sql server.

* Update dependency to arachne-commons release 1.17.1 #1774 (#1775)

* Eager loading without redundant calls for fetching collecions works only in 5.4.2.Final version of hibernate(#1758)

# Conflicts:
#	pom.xml

* Reset Impala settings to default(#1758)

* Updated org.ohdsi from 1.9.1 to 1.9.2 to to fix error in script(#1755) (#1778)

Co-authored-by: Sergey Suvorov <[email protected]>

* Updated org.apache.shiro from 1.6.0 to 1.7.1 to eliminate identified vulnerabilities  (#1759) (#1776)

Co-authored-by: Sergey Suvorov <[email protected]>

* Version 2.8.1

Co-authored-by: anton.abushkevich <anton.abushkevich>
Co-authored-by: Chris Knoll <[email protected]>
Co-authored-by: anton-abushkevich <[email protected]>
Co-authored-by: Sergey Suvorov <[email protected]>
Co-authored-by: Joris Borgdorff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment