Skip to content

Commit

Permalink
refactor(combineFrameInstance): Remove outdated comments and improve …
Browse files Browse the repository at this point in the history
…property assignment for ImagePositionPatient
  • Loading branch information
sedghi committed Jan 15, 2025
1 parent cc271a1 commit 6b9852c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions platform/core/src/utils/combineFrameInstance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ const combineFrameInstance = (frame, instance) => {
PerFrameFunctionalGroupsSequence?.[frameNumber]
);

// Note: do not assign directly to newInstance.ImagePositionPatient
// because it will also overwrite the instance.ImagePositionPatient since it
// is create via Object.create(parent)
Object.defineProperty(newInstance, 'ImagePositionPatient', {
value: ImagePositionPatientToUse ?? newInstance.ImagePositionPatient ?? [0, 0, frameNumber],
writable: true,
Expand Down

0 comments on commit 6b9852c

Please sign in to comment.