Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DICOMSR code to @ohif/core project #1282

Closed
dannyrb opened this issue Dec 11, 2019 · 0 comments
Closed

Move DICOMSR code to @ohif/core project #1282

dannyrb opened this issue Dec 11, 2019 · 0 comments
Assignees
@igoroctaviano

Comments

@dannyrb
Copy link
Member

dannyrb commented Dec 11, 2019

RE: #954

We've just merged support for DICOM Structured Reports. Today, support for this feature lives in the @ohif/viewer project in it's lib folder. Ideally, it should be moved to @ohif/core and given a clear public API and unit tests.

This would make the functionality easier to reuse, and easier to continue building on as we add support for other DICOM SR features.
igoroctaviano added a commit that referenced this issue Dec 17, 2019
@igoroctaviano
refactor: 💡 Move DICOMSR code to @OHIF/core project
38e0922 
We've just merged support for DICOM Structured Reports. Today, support
for this feature lives in the @ohif/viewer project in it's lib folder.
Ideally, it should be moved to @OHIF/core and given a clear public API
and unit tests.

Closes: #1282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igoroctaviano igoroctaviano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannyrb @igoroctaviano