Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance-level qualitative annotations not handled properly when there is more than one SR #2852

Closed
fedorov opened this issue Jul 28, 2022 · 7 comments · Fixed by #2888 or ImagingDataCommons/Viewers#150
Assignees
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor

Comments

@fedorov
Copy link
Member

fedorov commented Jul 28, 2022

It appears that if 2 SR instances with slice-level qualitative annotations are present, it is impossible to select the active one in the right-hand panel, and also there appears to be no labels with the annotations in the slice view.

@deepakri201 can share an example dataset.

Follow up on #2797

@fedorov fedorov added Community: Report 🐛 IDC:priority Items that the Imaging Data Commons wants to help sponsor labels Jul 28, 2022
@deepakri201
Copy link

It seems that the annotations only appear for one of the SR instances.

Here is an example dataset

@fedorov
Copy link
Member Author

fedorov commented Aug 24, 2022

@Punzo thanks for the quick fix! Can you maybe give a brief summary what was the underlying issue?

@Punzo
Copy link

Punzo commented Aug 24, 2022

@Punzo thanks for the quick fix! Can you maybe give a brief summary what was the underlying issue?

just an error in the parsing code, the second SR was overwriting the read data of the first, instead of appending.

I also fixed a couple of very minor issues in the UI

@deepakri201
Copy link

deepakri201 commented Aug 24, 2022

Thank you for the fix! Unfortunately, I think there may be a problem as I get the following error:

image

Here is a dropbox link the with the 2 SRs and the corresponding CT data.

I also noticed that in /platform/viewer/public/config/default.js, v9 is referenced. Could it be changed to v10?

Thanks!

@Punzo
Copy link

Punzo commented Aug 25, 2022

I also noticed that in /platform/viewer/public/config/default.js, v9 is referenced. Could it be changed to v10?

sure! done!

Here is a dropbox link the with the 2 SRs and the corresponding CT data.

ok I will check it out now

@Punzo
Copy link

Punzo commented Aug 25, 2022

@deepakri201 for me both datasets are working:
1)
Screenshot from 2022-08-25 09-59-36
2)
Screenshot from 2022-08-25 10-00-06

However, In your screenshot I see a study with a segmentation and two SRs, but no CT data (while I have in both data test 1 CT and 2 SR). Probably it is related to pointing v9 vs v10 release in the config. Can you please double check if v10 release has fixed the issue? Thanks

@deepakri201
Copy link

Hi,

Thanks for taking a look -- I should have mentioned that I'm using this branch: https://github.com/ImagingDataCommons/Viewers/tree/IDC2servers

I realized that I made a mistake in how I was deploying our OHIF instance, once I fixed that, everything looks great :)

image

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
3 participants