Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After changing the CT or PET in TMTV mode the coronal and sagital images zoom way in (turn grey) [Bug] #3758

Closed
BrandonDatUHN opened this issue Nov 2, 2023 · 8 comments
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@BrandonDatUHN
Copy link

Describe the Bug

When viewing PET-CT images in TMTV mode changing the PET or CT using drag and drop causes the coronal and sagittal frames to zoom so far in that they appear to have disappeared entirely.

https://watch.screencastify.com/v/utGfh9WB1dyaMYrBst2n

Steps to Reproduce

  1. Go to https://viewer.ohif.org/tmtv?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.871108593056125491804754960339 or any of the other PET-CT series on OHIF demo v 3.7
  2. undock the thumbnails panel
  3. drag the NAC PET or a different CT than the one selected into the appropriate frame of the TMTV grid
  4. Coronal and sagittal panels will zoom way in so they appear grey or black
    image
  5. zoom back out on the panel to reveal the image is actually zoomed way in (and shifted slightly)
    image

The current behavior

When switching the CT or PET series in TMTV mode using drag and drop the coronal and sagittal panels zoom way in so that they appear as a single colour/voxel

The expected behavior

After switching panels the coronal and sagittal should load at the same zoom level as the axial following the same behaviour as when first loading the TMTV hanging protocol

OS

Windows 10

Node version

whatever is on OHIF demo

Browser

Both Edge Version 118.0.2088.76 (Official build) (64-bit) and Chrome Version 118.0.5993.118 (Official Build) (64-bit)

@BrandonDatUHN BrandonDatUHN added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 2, 2023
@salimkanoun
Copy link
Contributor

Yes I confirm this bug, this is due to an erroneous zoom and pan and probably due to setOrientation API on volume viewport (I guess when you change the display set the HP service call this API)

The same bug is visible when you call the setOrientation API on volume viewport,
Interestingly this happen on the first call on the setOrientation API the zoom and pan are lost
if you call immediatly a second time this API the zoom and pan are properly restaured

@sedghi
Copy link
Member

sedghi commented Nov 2, 2023

@salimkanoun Can we reproduce this in cornerstone examples?

@salimkanoun
Copy link
Contributor

I guess we could see it in this one but seems broken, https://www.cornerstonejs.org/live-examples/volumeviewportorientation

I'm missing time to fix it, but i think by activating the zoom tool in this example, changing the zoom manuall and chaging orientation should duplicate the problem

@sedghi
Copy link
Member

sedghi commented Nov 2, 2023

I fixed that example (will push soon) but seems like it is not what you suggested for reproducible steps. I think it is related to the synchronizers

@salimkanoun
Copy link
Contributor

Hum possible we changed the camera orientation while we had 3 orthogonal viewport synced in position

@BrandonDatUHN
Copy link
Author

Any updates on this one? Looks to still be present in v3.8.0-beta.10

@sedghi sedghi added Bugs Bug reported, reproducible, and verified. Awaiting Reproduction Can we reproduce the reported bug? and removed Awaiting Reproduction Can we reproduce the reported bug? labels Nov 10, 2023
@sedghi
Copy link
Member

sedghi commented Jan 9, 2024

This is fixed in dev branch just FYI

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Awaiting Reproduction Can we reproduce the reported bug? Bugs Bug reported, reproducible, and verified. labels Jan 9, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

3 participants