Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON server configuration launch #2791

Merged
merged 6 commits into from
May 1, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions extensions/cornerstone/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ export default {
* @param {object} [configuration={}]
* @param {object|array} [configuration.csToolsConfig] - Passed directly to `initCornerstoneTools`
*/
preRegistration({ servicesManager, commandsManager, configuration = {} }) {
init({ servicesManager, commandsManager, configuration });
preRegistration({
servicesManager,
commandsManager,
appConfig,
configuration = {},
}) {
init({ servicesManager, commandsManager, appConfig, configuration });
},
getViewportModule({ servicesManager, commandsManager }) {
const ExtendedOHIFCornerstoneViewport = props => {
Expand Down
4 changes: 3 additions & 1 deletion extensions/cornerstone/src/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ const _createInternalToolsConfig = UIDialogService => {
export default function init({
servicesManager,
commandsManager,
appConfig,
configuration,
}) {
const {
Expand Down Expand Up @@ -276,7 +277,8 @@ export default function init({

cs.metaData.addProvider(metadataProvider.get.bind(metadataProvider), 9999);

initWADOImageLoader(UserAuthenticationService);
const { imageLoaderAcceptHeader } = appConfig;
initWADOImageLoader(UserAuthenticationService, imageLoaderAcceptHeader);

// ~~
const defaultCsToolsConfig = csToolsConfig || {
Expand Down
9 changes: 6 additions & 3 deletions extensions/cornerstone/src/initWADOImageLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ function initWebWorkers() {
}
}

export default function initWADOImageLoader(UserAuthenticationService) {
export default function initWADOImageLoader(
UserAuthenticationService,
imageLoaderAcceptHeader = 'multipart/related; type=application/octet-stream'
) {
cornerstoneWADOImageLoader.external.cornerstone = cornerstone;
cornerstoneWADOImageLoader.external.dicomParser = dicomParser;

Expand All @@ -38,8 +41,8 @@ export default function initWADOImageLoader(UserAuthenticationService) {
// For now we use image/jls and image/x-jls because some servers still use the old type
// http://dicom.nema.org/medical/dicom/current/output/html/part18.html
const xhrRequestHeaders = {
// To prevent Preflight requests:
accept: 'multipart/related; type=application/octet-stream',
// Preflight requests disabled by default:
accept: imageLoaderAcceptHeader,
//
//accept: 'multipart/related; type="image/x-jls"',
// 'multipart/related; type="image/x-jls", multipart/related; type="image/jls"; transfer-syntax="1.2.840.10008.1.2.4.80", multipart/related; type="image/x-jls", multipart/related; type="application/octet-stream"; transfer-syntax=*',
Expand Down
74 changes: 74 additions & 0 deletions extensions/default/src/DicomWebProxyDataSource/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
import { IWebApiDataSource } from '@ohif/core';
import { createDicomWebApi } from '../DicomWebDataSource/index';

function createDicomWebProxyApi(
dicomWebProxyConfig,
UserAuthenticationService
) {
const { name } = dicomWebProxyConfig;
let dicomWebDelegate = undefined;

const implementation = {
initialize: async ({ params, query, url }) => {
let studyInstanceUIDs = [];

if (!url) url = query.get('url');

if (!url) {
console.error(`No url for '${name}'`);
} else {
const response = await fetch(url);
let data = await response.json();

// there seem to be a couple of variations of the case for this parameter
const queryStudyInstanceUIDs =
query.get('studyInstanceUIDs') || query.get('studyInstanceUids');
if (!queryStudyInstanceUIDs) {
console.error(`No studyInstanceUids in request for '${name}'`);
}
if (data.servers && queryStudyInstanceUIDs) {
dicomWebDelegate = createDicomWebApi(
data.servers.dicomWeb[0],
UserAuthenticationService
);
studyInstanceUIDs = queryStudyInstanceUIDs.split(';');
}
}
return studyInstanceUIDs;
},
query: {
studies: {
search: params => dicomWebDelegate.query.studies.search(params),
},
series: {
search: (...args) => dicomWebDelegate.query.series.search(...args),
},
instances: {
search: (studyInstanceUid, queryParameters) =>
dicomWebDelegate.query.instances.search(
studyInstanceUid,
queryParameters
),
},
},
retrieve: {
directURL: (...args) => dicomWebDelegate.retrieve.directURL(...args),
series: {
metadata: (...args) =>
dicomWebDelegate.retrieve.series.metadata(...args),
},
},
store: {
dicom: (...args) => dicomWebDelegate.store(...args),
},
deleteStudyMetadataPromise: (...args) =>
dicomWebDelegate.deleteStudyMetadataPromise(...args),
getImageIdsForDisplaySet: (...args) =>
dicomWebDelegate.getImageIdsForDisplaySet(...args),
getImageIdsForInstance: (...args) =>
dicomWebDelegate.getImageIdsForInstance(...args),
};
return IWebApiDataSource.create(implementation);
}

export { createDicomWebProxyApi };
6 changes: 6 additions & 0 deletions extensions/default/src/getDataSourcesModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import { createDicomWebApi } from './DicomWebDataSource/index.js';
import { createDicomJSONApi } from './DicomJSONDataSource/index.js';
import { createDicomLocalApi } from './DicomLocalDataSource/index.js';
import { createDicomWebProxyApi } from './DicomWebProxyDataSource/index.js';

/**
*
Expand All @@ -16,6 +17,11 @@ function getDataSourcesModule() {
type: 'webApi',
createDataSource: createDicomWebApi,
},
{
name: 'dicomwebproxy',
type: 'webApi',
createDataSource: createDicomWebProxyApi,
},
{
name: 'dicomjson',
type: 'jsonApi',
Expand Down
10 changes: 10 additions & 0 deletions platform/viewer/public/config/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ window.config = {
modes: [],
showStudyList: true,
// filterQueryParam: false,
// enable imageLoaderAcceptHeader configuration to force a reconfiguration of WADOImageLoader to support preflight request
// imageLoaderAcceptHeader: 'multipart/related; type="application/octet-stream"',
dataSources: [
{
friendlyName: 'dcmjs DICOMWeb Server',
Expand All @@ -24,6 +26,14 @@ window.config = {
supportsWildcard: true,
},
},
{
friendlyName: 'dicomweb delegating proxy',
namespace: '@ohif/extension-default.dataSourcesModule.dicomwebproxy',
sourceName: 'dicomwebproxy',
configuration: {
name: 'dicomwebproxy',
},
},
{
friendlyName: 'dicom json',
namespace: '@ohif/extension-default.dataSourcesModule.dicomjson',
Expand Down