Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDC: Fix minor issues IDC #2903

Merged
merged 1 commit into from
Aug 31, 2022
Merged

IDC: Fix minor issues IDC #2903

merged 1 commit into from
Aug 31, 2022

Conversation

Punzo
Copy link

@Punzo Punzo commented Aug 31, 2022

IDC: Fix minor issues ImagingDataCommons/IDC-WebApp#1030

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #2903 (2696f44) into master (fe57c00) will decrease coverage by 0.26%.
The diff coverage is 2.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2903      +/-   ##
==========================================
- Coverage   12.68%   12.41%   -0.27%     
==========================================
  Files         306      307       +1     
  Lines        8233     8424     +191     
  Branches     1593     1671      +78     
==========================================
+ Hits         1044     1046       +2     
- Misses       5797     5909     +112     
- Partials     1392     1469      +77     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.63% <0.00%> (-0.76%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
platform/core/src/utils/StackManager.js 11.62% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
...ons/MeasurementsPanel/ConnectedMeasurementTable.js 0.00% <ø> (ø)
...c/appExtensions/MeasurementsPanel/jumpToRowItem.js 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850de29...2696f44. Read the comment docs.

@Punzo Punzo merged commit ef60156 into OHIF:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant