Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotkey page up/down does not work #2910

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix hotkey page up/down does not work #2910

merged 1 commit into from
Sep 8, 2022

Conversation

horner
Copy link
Contributor

@horner horner commented Sep 5, 2022

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #2910 (ef944d6) into master (fe57c00) will decrease coverage by 0.72%.
The diff coverage is 2.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   12.68%   11.95%   -0.73%     
==========================================
  Files         306      307       +1     
  Lines        8233     8439     +206     
  Branches     1593     1675      +82     
==========================================
- Hits         1044     1009      -35     
- Misses       5797     5947     +150     
- Partials     1392     1483      +91     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.63% <0.00%> (-0.76%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) ⬇️
platform/core/src/utils/StackManager.js 11.62% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
...Extensions/GenericViewerCommands/commandsModule.js 0.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfde92...ef944d6. Read the comment docs.

@horner horner changed the title Fix https://github.com/OHIF/Viewers/issues/2870 hotkey does not work Fix hotkey page up/down does not work Sep 5, 2022
horner added a commit to mieweb/OHIF-Viewers that referenced this pull request Sep 5, 2022
@sedghi sedghi merged commit d74ad37 into OHIF:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants