Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDC Re #2918: Runtime tolerance for SEGs loading #2924

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix IDC Re #2918: Runtime tolerance for SEGs loading #2924

merged 1 commit into from
Sep 12, 2022

Conversation

Punzo
Copy link

@Punzo Punzo commented Sep 12, 2022

Adds #2918

Hera a video:

  1. setting the default tolerance to 1e-7
  2. the segs loading fails
  3. change parameter in the Segs settings panel
  4. reload successfully the data
2022-09-12.13-17-57.mp4

P.S.: the default value was set to 1e-7 only for this video to demostrate the feature. The defafult one is 1e-2 (which affter many issues, we defined as a good compromise for IDC cases).

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #2924 (ed5d7a9) into master (fe57c00) will decrease coverage by 0.72%.
The diff coverage is 2.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   12.68%   11.95%   -0.73%     
==========================================
  Files         306      307       +1     
  Lines        8233     8439     +206     
  Branches     1593     1675      +82     
==========================================
- Hits         1044     1009      -35     
- Misses       5797     5947     +150     
- Partials     1392     1483      +91     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.63% <0.00%> (-0.76%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
platform/core/src/classes/HotkeysManager.js 76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) ⬇️
platform/core/src/utils/StackManager.js 11.62% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbc9e0...ed5d7a9. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 12, 2022



Test summary

76 0 0 0


Run details

Project Viewers
Status Passed
Commit ed5d7a9
Started Sep 12, 2022 12:14 PM
Ended Sep 12, 2022 12:21 PM
Duration 06:39 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant