Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› Missing SpacingBetweenSlices prevents SEG rendering #3344

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

igoroctaviano
Copy link
Contributor

Update displaySet metadata parsing logic to extract SpacingBetweenSlices
from SharedFunctionalGroupsSequence / PixelMeasuresSequence

βœ… Closes: #3335

Update displaySet metadata parsing logic to extract SpacingBetweenSlices
from SharedFunctionalGroupsSequence / PixelMeasuresSequence

βœ… Closes: #3335
@netlify
Copy link

netlify bot commented Apr 28, 2023

βœ… Deploy Preview for ohif-platform-docs canceled.

Name Link
πŸ”¨ Latest commit 43a3111
πŸ” Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/644c263d5d0ed30008d9b089

@netlify
Copy link

netlify bot commented Apr 28, 2023

βœ… Deploy Preview for ohif-platform-viewer ready!

Name Link
πŸ”¨ Latest commit 43a3111
πŸ” Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/644c263d99bb650008786d22
😎 Deploy Preview https://deploy-preview-3344--ohif-platform-viewer.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #3344 (43a3111) into v3-stable (9f1e813) will increase coverage by 13.35%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #3344       +/-   ##
==============================================
+ Coverage      25.15%   38.50%   +13.35%     
==============================================
  Files            119       82       -37     
  Lines           2862     1340     -1522     
  Branches         555      302      -253     
==============================================
- Hits             720      516      -204     
+ Misses          1856      659     -1197     
+ Partials         286      165      -121     

see 76 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dd3944a...43a3111. Read the comment docs.

@cypress
Copy link

cypress bot commented Apr 28, 2023

Passing run #3155 β†—οΈŽ

0 36 0 0 Flakiness 0

Details:

fix: πŸ› Missing SpacingBetweenSlices prevents SEG rendering
Project: Viewers Commit: 43a31115ec
Status: Passed Duration: 03:45 πŸ’‘
Started: Apr 28, 2023 9:11 PM Ended: Apr 28, 2023 9:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing SpacingBetweenSlices is preventing Segmentation to be rendered
2 participants