chore(version): update cs3d version and add iframe documentation #3474
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ohif-dev canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 82 82
Lines 1348 1348
Branches 303 303
=======================================
Hits 516 516
Misses 666 666
Partials 166 166 Continue to review full report in Codecov by Sentry.
|
sedghi
changed the title
| You need to make sure that the viewer is also built with PUBLIC_URL set to the same path. For example, if you using | ||
| `<iframe src="./ohif" />` (which means there is a `ohif` folder containing the build in your main app), then you need to: | ||
|
|
||
| 1. use a config file that is using the `routerBasename` of `/ohif` (note the one / - it is not /ohif/). |
There was a problem hiding this comment.
To maybe make step 2 less verbos, say. "use a config file (say myConfig.js) that has routerBasename set to \ohif (note the one / - it is not /ohif/)."
There was a problem hiding this comment.
I don't have a myConfig.js so I think it is fine to explain a bit more
There was a problem hiding this comment.
By adding "(say myConfig.js)" you are saying exactly that to "pretend the config file is named myConfig.js". So please reconsider adding it in.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment