fix(date formatting): Show study date as a fallback for an empty series date and show 'No Study Date' as a back up for both #3483
Conversation
…panel when no study date is present in the DICOM. Likewise, in the viewport action bar, when no series date is present, show the study date and if neither are present, show 'No Study Date'.
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -134,7 +134,7 @@ function PanelStudyBrowserTracking({ | |||
| const actuallyMappedStudies = mappedStudies.map(qidoStudy => { | |||
| return { | |||
| studyInstanceUid: qidoStudy.StudyInstanceUID, | |||
| date: formatDate(qidoStudy.StudyDate), | |||
| date: formatDate(qidoStudy.StudyDate) || 'No Study Date', | |||
There was a problem hiding this comment.
This is what was suggested in the reporting issue. However we can discuss alternatives.
There was a problem hiding this comment.
N/A could apply to anything... not just a date. If someone sees N/A, they do not know what it is referring to. So no, I do not think N/A is appropriate. How about just 'No Date'.
There was a problem hiding this comment.
Also N/A stands for not applicable. So I really don't think that is right.
There was a problem hiding this comment.
@wayfarer3130 What should be here if it is empty?
There was a problem hiding this comment.
Probably it should be an empty string if it is missing, then the UI can decide on the value to show when empty.
There was a problem hiding this comment.
@wayfarer3130, this is the UI. For me, the question is what to show in the UI.
There was a problem hiding this comment.
What about 'No Study Data' or 'No Date'
There was a problem hiding this comment.
I'm asking Dan about what to show.
There was a problem hiding this comment.
Agreed with No Study Date
Codecov Report
@@ Coverage Diff @@
## master #3483 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 82 82
Lines 1348 1348
Branches 303 304 +1
=======================================
Hits 516 516
+ Misses 666 665 -1
- Partials 166 167 +1
Continue to review full report in Codecov by Sentry.
|
|
@jbocce - could you update the branch please? |
…orrectly-showing-current-date-for-blank-study-and-series-dates
done |
Context
See #3458
Changes & Results
Show 'No Study Date' in the study browser side panel when no study date is present in the DICOM.
Likewise, in the viewport action bar, when no series date is present, show the study date and if neither are present, show 'No Study Date'.
Testing
See #3458 for steps to reproduce the original problem.
As a regression test, ensure those studies with study and series dates defined work as expected.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment