-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(invert): allows volume viewport to invert as it is implemented now #3514
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3514 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
Passing run #3354 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I tested using a local link of the CS3D changes.
Clicking invert once MPR has started works correctly.
However, if prior to launching MPR the image is inverted, once MPR is launched I found that the images were NOT inverted. Not sure what the expected behaviour is here, but please have a look and let me know your thoughts.
Please update the package.json files to get the CS3D changes.
Thanks for updating the CS3D imports. Looks like there are code conflicts now. Please resolve them. Also I found this one scenario where an already inverted image is not inverted when MPR is launched...
ScreenHunter.Jul.06.11.04.mp4 |
I saw what you said too, it is a bug but I will handle it in another PR. Since it is related to the state sync service, another bug is.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It is good to go.
Context
In MPR we were not able to invert viewports
Changes & Results
Needs cornerstone PR to get merged cornerstonejs/cornerstone3D#677
But also it enables running the command for volume viewport too
Testing
After cornerstone js PR gets merged, you should be able to invert one viewport in MPR and all gets inverted
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment