Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invert): allows volume viewport to invert as it is implemented now #3514

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jul 4, 2023

Context

In MPR we were not able to invert viewports

Changes & Results

Needs cornerstone PR to get merged cornerstonejs/cornerstone3D#677
But also it enables running the command for volume viewport too

Testing

After cornerstone js PR gets merged, you should be able to invert one viewport in MPR and all gets inverted

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 8644c98
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64a6e16681fb6700089fa4c0
😎 Deploy Preview https://deploy-preview-3514--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 8644c98
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64a6e166401a400008e9b978
😎 Deploy Preview https://deploy-preview-3514--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3514 (8644c98) into master (61595ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3514   +/-   ##
=======================================
  Coverage   42.81%   42.81%           
=======================================
  Files          82       82           
  Lines        1448     1448           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        665      665           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a4f86...8644c98. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 4, 2023

Passing run #3354 ↗︎

0 36 0 0 Flakiness 0

Details:

Merge branch 'master' of github.com:OHIF/Viewers into fix/invert-viewport-with-s...
Project: Viewers Commit: 8644c98880
Status: Passed Duration: 03:44 💡
Started: Jul 6, 2023 3:50 PM Ended: Jul 6, 2023 3:54 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I tested using a local link of the CS3D changes.

Clicking invert once MPR has started works correctly.

However, if prior to launching MPR the image is inverted, once MPR is launched I found that the images were NOT inverted. Not sure what the expected behaviour is here, but please have a look and let me know your thoughts.

Please update the package.json files to get the CS3D changes.

@jbocce
Copy link
Collaborator

jbocce commented Jul 6, 2023

Thanks for updating the CS3D imports.

Looks like there are code conflicts now. Please resolve them.

Also I found this one scenario where an already inverted image is not inverted when MPR is launched...

  1. Launch MPR.
  2. Invert one of the views.
  3. Toggle back the invert.
  4. Exit MPR.
  5. Invert the image.
  6. Launch MPR. Notice that the views are not inverted. Should they be?
ScreenHunter.Jul.06.11.04.mp4

@sedghi
Copy link
Member Author

sedghi commented Jul 6, 2023

I saw what you said too, it is a bug but I will handle it in another PR. Since it is related to the state sync service, another bug is.

  1. open study
  2. drag series 1 in viewport 1
  3. drag series 1 in viewport 2
  4. modify w/l for window level 2
  5. go mpr
  6. (it succuessfully carries w/l of vp 2)
  7. go back to stack
  8. now both viewports have the same w/l of vp 2
  9. it is a bug

Copy link
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants