-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rerendering): reduce the re-rendering of the viewport grid #3558
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #3558 +/- ##
=======================================
Coverage 42.93% 42.93%
=======================================
Files 80 80
Lines 1444 1444
Branches 338 338
=======================================
Hits 620 620
Misses 661 661
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
} | ||
/> | ||
)} | ||
<CinePlayer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this setup with just instantiating the component rather than passing all sorts of extra services in.
viewportIndex, | ||
servicesManager, | ||
}) { | ||
const { toolbarService } = servicesManager.services; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you consider getting the customization service here and if the customization service defines a cine player, then returning that CINE player instead of this one? That way the user can replace the CINE player entirely should the mode decide they want to do that. I've seen several implementations of different CINE players, so it is clearly something that people want to customize in the mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see the disabled use on the tree rather than the remove/add of the entire outside click handler.
Context
There were unnecessary re-renderings through out the app
Testing
Use react profiler and you will see these re-renders
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment