Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OHI-1483] fix(tag-browser): fix dicom tag browser not loading in segmentation mode in study panel #4601

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Dec 13, 2024

Context

DICOM Tag Brower was not working in segmentation mode. The issue was that the commandsManager was not passed to the panel. This is now resolved.

Fixes #4595

@IbrahimCSAE IbrahimCSAE changed the title fix(tag-browser): fix dicom tag browser not loading in segmentation mode in study panel [OHI-1483] fix(tag-browser): fix dicom tag browser not loading in segmentation mode in study panel Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e1366d9
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/675ba18e272b73000848d271
😎 Deploy Preview https://deploy-preview-4601--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 13, 2024

Viewers    Run #4546

Run Properties:  status check passed Passed #4546  •  git commit e1366d9465: fix dicom tag browser in segmentation mode
Project Viewers
Branch Review fix/dicom-tag-browser-seg
Run status status check passed Passed #4546
Run duration 02m 09s
Commit git commit e1366d9465: fix dicom tag browser in segmentation mode
Committer Ibrahim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit e1366d9
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/675ba18e39e56e0008fa09b6
😎 Deploy Preview https://deploy-preview-4601--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi December 13, 2024 05:36
@sedghi sedghi merged commit 60fc7d6 into master Dec 13, 2024
20 checks passed
@sedghi sedghi deleted the fix/dicom-tag-browser-seg branch January 14, 2025 20:23
sedghi pushed a commit that referenced this pull request Jan 16, 2025
@sedghi sedghi mentioned this pull request Jan 16, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /ohif/segmentation tag viewer does not work
2 participants