fix(seg): jump to the first slice in SEG and RT that has data #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cornerstone: Update SEG and SR viewports and enhance segmentation service - Added `usePositionPresentationStore` to `OHIFCornerstoneSEGViewport.tsx` to set position presentation for SEG viewports - Improved SR measurement viewport by streamlining props and enhancing `setPositionPresentation` logic - Modified `frameView.ts` and hanging protocols to adjust display set weights from 10 to 20 for better URL-based display set handling - Enhanced `SegmentationService` to track the first non-zero voxel image ID for SEG display sets - Refined `CornerstoneViewportService` to set initial image index based on referenced image ID and manage overlay functions - Enabled DICOM upload in `local_orthanc.js` configuration - Updated `yarn.lock` to use the latest versions of CornerstoneJS dependencies ```
Cornerstone DICOM: Update viewport and RT structure handling - Add `presentationIds` to viewport options for `OHIFCornerstonePMAPViewport` and `OHIFCornerstoneRTViewport` to enhance presentation management. - Introduce `ReferencedSOPInstanceUIDsSet` in `loadRTStruct` to track referenced SOP instances. - Modify contour processing to include `ContourImageSequence` and update `ReferencedSOPInstanceUIDsSet` accordingly. - Use `usePositionPresentationStore` in `OHIFCornerstoneRTViewport` to manage position presentations. - Replace `firstNonZeroVoxelImageId` with `firstSegmentedSliceImageId` for consistency in segmentation handling. - Ensure `firstSegmentedSliceImageId` is correctly assigned in `SegmentationService` and referenced in viewports. ```
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
changed the title
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/initial-seg-rt
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
wayfarer3130
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4593
and it fixes the initial slice to load for SEG and RTSTRUCT to be the slice that has data and is not empty