fix/multiframe stuff again #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/multiframe-stuff-again
|
| Run status |
|
| Run duration | 02m 14s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
commit ea24f1d Author: Bill Wallace <[email protected]> Date: Wed Jan 15 18:18:59 2025 -0500 Use index for child values commit ff19c65 Author: Bill Wallace <[email protected]> Date: Wed Jan 15 18:14:16 2025 -0500 Use shared child elements commit 94d13a4 Author: Bill Wallace <[email protected]> Date: Wed Jan 15 18:12:23 2025 -0500 fix: Overwriting hte combined instance values
Co-authored-by: Chao Sui <[email protected]>
sedghi
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Bill Wallace <[email protected]> Co-authored-by: Chao Sui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4585
fixes #4630
fixes #4528
related to #4685