multi-tenant: Basic multi-tenant selector tests #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlucovsky
force-pushed
the
6237/1
branch
2 times, most recently
from
eeb8c06 to
69a78a4
Compare
|
What happens when you have 2 inner vlan's with the same ID, but different outer IDs? Or is that not a normal deployment scenario? |
|
Good point. It’s a customer issue and they must be aware of that possibility. The customer requested this as they are incorporating a legacy network where the inner vlans are unique across the total deployed vlan range.
Should the doc bring that point up more strongly?
|
jlucovsky
force-pushed
the
6237/1
branch
2 times, most recently
from
795a483 to
a1020da
Compare
|
Suricata PR for reference is OISF/suricata#9729 |
jlucovsky
force-pushed
the
6237/1
branch
2 times, most recently
from
869043b to
713cd60
Compare
This commit adds basic tests for vlan-selector configurations (including vlan-tuple, added in 6237) Issue: 6237
|
Should this have |
catenacyber
requested changes
Jun 11, 2024
|
Closed for further evaluation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic tests for vlan-selector configurations (including vlan-pair, added in 6237)
Issue: 6237
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6237