Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/sv/154/20231030/v1 #1448

Merged
merged 2 commits into from
Oct 31, 2023
Merged

next/sv/154/20231030/v1 #1448

merged 2 commits into from
Oct 31, 2023

Conversation

victorjulien
Copy link
Member

jlucovsky and others added 2 commits October 27, 2023 09:00
@jlucovsky
detect/bytejump: Test from issue 4623
f0c6d49 
Issue: 4623

This commit uses the pcap and rules from issue 4623 to validate the
fixes.
@jasonish @victorjulien
test: test for empty dns/eve formats
ee229ca 
Test that when dns/eve "formats" is empty, it uses the default of all.

Bug: #6420
@victorjulien victorjulien merged commit ee229ca into OISF:master Oct 31, 2023
1 of 5 checks passed
This was referenced Oct 31, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @jlucovsky @jasonish