test: add test for dns.rcode #1563
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Test the `dns.rcode` sticky buffer. | ||
|
|
||
| The PCAP here was a request created with Scapy to include answers in | ||
| the request. However the response is from a real DNS server with the | ||
| provided request. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Should alert in both directions as no flow is provided. | ||
| alert dns any any -> any any (dns.rcode; content:"oisf"; sid:1; rev:1;) | ||
|
There was a problem hiding this comment. should it not be something like There was a problem hiding this comment. Since it's an integer keyword ;) |
||
|
|
||
| # Should only alert in the request direction. | ||
| alert dns any any -> any any (dns.rcode; content:"oisf"; flow:to_server; sid:2; rev:1;) | ||
|
|
||
| # Should only alert in the response direction. | ||
| alert dns any any -> any any (dns.rcode; content:"oisf"; flow:to_client; sid:3; rev:1;) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| requires: | ||
| min-version: 8 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 2 | ||
| match: | ||
| alert.signature_id: 1 | ||
| app_proto: dns | ||
|
Comment on lines
+8
to
+9
There was a problem hiding this comment. it's important to add a check for the rcode field on the checks, too :) |
||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 1 | ||
| direction: to_client | ||
| app_proto: dns | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 1 | ||
| direction: to_server | ||
| app_proto: dns | ||
|
|
||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 2 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 2 | ||
| direction: to_server | ||
| app_proto: dns | ||
|
|
||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 3 | ||
|
There was a problem hiding this comment. You can have only one filter per signature id, right ? |
||
| - filter: | ||
| count: 1 | ||
| match: | ||
| alert.signature_id: 3 | ||
| direction: to_client | ||
| app_proto: dns | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a reference to the redmine ticket :)
If you do re-use a pcap from a different test, you can indicate that here, too.