Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applayer: add test for dcerpc req http resp #2160

Closed
wants to merge 1 commit into from
Closed

applayer: add test for dcerpc req http resp #2160

wants to merge 1 commit into from

Conversation

inashivb
Copy link
Member

@inashivb inashivb commented Dec 4, 2024 •
edited
Loading

Previous PR: #2140

Changes since v2:

  • fixed the pcap and the expected output. Now the output is exactly as expected by the unittest that is being converted here

@inashivb
applayer: add test for dcerpc req http resp
23ccd56 
as done in the unittest AppLayerTest08 as of Suricata 278dc24c.
@inashivb inashivb force-pushed the dcerpc-request-http-response/v3 branch from ce16139 to 23ccd56 Compare December 4, 2024 10:40
@inashivb inashivb added the tests pass These new tests should pass label Dec 4, 2024
@inashivb inashivb mentioned this pull request Dec 4, 2024
Closed
@victorjulien victorjulien mentioned this pull request Dec 14, 2024
Merged
@victorjulien
Copy link
Member

Merged in #2186, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
tests pass These new tests should pass
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inashivb @victorjulien