test: add test for ldap.request.operation - v1 #2206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7453
5 tasks
catenacyber
reviewed
Dec 24, 2024
|
|
||
| ## PCAP | ||
|
|
||
| This PCAP was generated with flowsynth v1.4.1. |
There was a problem hiding this comment.
I wonder if you can simply reuse some (not all) ldap tests and add a rules file with them
catenacyber
reviewed
Dec 24, 2024
catenacyber
reviewed
Dec 24, 2024
| @@ -0,0 +1,9 @@ | |||
| alert tcp any any -> any any (msg:"Test LDAP bind request"; ldap.request.operation:0; sid:1;) | |||
There was a problem hiding this comment.
This is good for a first iteration.
In a next iteration, we want to have both signatures ldap.request.operation:0; and ldap.request.operation:bind; (I say bind but we should take whatever is being logged as metadata)
See websocket.opcode and usage of git grep EnumString in suricata
|
Replaced by #2216 right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 7453
Description:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7453
Suricata PR: OISF/suricata#12321