Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/sv/682/20250108/v1 #2221

Merged
merged 2 commits into from
Jan 9, 2025
Merged

next/sv/682/20250108/v1 #2221

merged 2 commits into from
Jan 9, 2025

Conversation

victorjulien
Copy link
Member

jlucovsky and others added 2 commits January 8, 2025 17:06
@jlucovsky @victorjulien
tests/lua: Test for issue 7466
e6941fb 
This test was contributed by the reporter of issue 7466. Slight
modifications not affecting the structure nor results were made.

This test exercises the problem reported in the issue and a memory leak
will be reported on Suricata binaries without the fix (ASAN-only).

Non-ASAN builds will not report the issue (regardless of whether the
Suricata fix is included).
@catenacyber @victorjulien
dns: update 7018 tests for suricata 8
836cd9a 
using dns v3 logging

Ticket: 7199

This also fixes ticket 7449
@victorjulien victorjulien mentioned this pull request Jan 8, 2025
Merged
inashivb
inashivb approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit 836cd9a into OISF:master Jan 9, 2025
3 of 5 checks passed
This was referenced Jan 9, 2025
Closed
Closed
@victorjulien victorjulien deleted the next/sv/682/20250108/v1 branch January 9, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @inashivb @jlucovsky @catenacyber