Flow timing/v4.1 stream rst/v1.1 v2 #2226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test checked for a flow log being generated by shutdown, but it is possible to have the flow manager handle it before shutdown. So in that case it would be "timeout". Since the test isn't about that, remove the check.
Tests various forms of RST triggering handling of unACK'd data.
Add tests for bad handling of unacked data following a RST. The additional data should not lead to new tx's or files.
This was referenced Jan 9, 2025
catenacyber
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM after looking git diff pr/2215 pr/2226 -- tcp*
Thanks for adding the ticker reference about https://redmine.openinfosecfoundation.org/issues/7238
|
Merged in #2227, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #2215, reducing yaml sizes and clarifying an issue related to https://redmine.openinfosecfoundation.org/issues/7238