Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ftp: FTP command tests #2242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+96 −0
Open

test/ftp: FTP command tests #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/detect-ftp/ftp-command-01/input.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
alert ftp any any -> any any (msg: "Match on FTP command PASS"; flow:to_server; ftp.command; content:"PASS"; sid:1;)
alert ftp any any -> any any (msg: "Match on FTP command USER"; flow:to_server; ftp.command; content:"USER"; sid:2;)
alert ftp any any -> any any (msg: "Match on FTP command NLST"; flow:to_server; ftp.command; content:"NLST"; sid:3;)
alert ftp any any -> any any (msg: "Match on FTP command PORT"; flow:to_server; ftp.command; content:"PORT"; sid:4;)
alert ftp any any -> any any (msg: "Match on FTP command RETR"; flow:to_server; ftp.command; content:"RETR"; sid:5;)
alert ftp any any -> any any (msg: "Match on FTP command QUIT"; flow:to_server; ftp.command; content:"QUIT"; sid:6;)

# Wrong direction -- won't match
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"PASS"; sid:10;)
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"USER"; sid:20;)
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"NLST"; sid:30;)
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"PORT"; sid:40;)
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"RETR"; sid:50;)
#alert ftp any any -> any any (flow:to_client; ftp.command; content:"QUIT"; sid:60;)
49 changes: 49 additions & 0 deletions tests/detect-ftp/ftp-command-01/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
pcap: ../../bug-3519/input.pcap

requires:
version: 8


checks:
- filter:
count: 1
match:
event_type: alert
ftp.command: USER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the alert.signature_id checks here as well? Want to make sure the correct sig matches in each case


- filter:
count: 1
match:
event_type: alert
ftp.command: PASS

- filter:
count: 1
match:
event_type: alert
ftp.command: NLST

- filter:
count: 2
match:
event_type: alert
ftp.command: PORT

- filter:
count: 1
match:
event_type: alert
ftp.command: RETR

- filter:
count: 1
match:
event_type: alert
ftp.command: QUIT

- filter:
count: 0
match:
event_type: alert
signature_id: 10

7 changes: 7 additions & 0 deletions tests/detect-ftp/ftp-command-02/input.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Wrong direction -- won't load
alert ftp any any -> any any (flow:to_client; ftp.command; content:"PASS"; sid:10;)
alert ftp any any -> any any (flow:to_client; ftp.command; content:"USER"; sid:20;)
alert ftp any any -> any any (flow:to_client; ftp.command; content:"NLST"; sid:30;)
alert ftp any any -> any any (flow:to_client; ftp.command; content:"PORT"; sid:40;)
alert ftp any any -> any any (flow:to_client; ftp.command; content:"RETR"; sid:50;)
alert ftp any any -> any any (flow:to_client; ftp.command; content:"QUIT"; sid:60;)
26 changes: 26 additions & 0 deletions tests/detect-ftp/ftp-command-02/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
pcap: ../../bug-3519/input.pcap

requires:
version: 8

exit-code: 1

checks:
- shell:
args: grep "rule 10 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
- shell:
args: grep "rule 20 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
- shell:
args: grep "rule 30 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
- shell:
args: grep "rule 40 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
- shell:
args: grep "rule 50 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
- shell:
args: grep "rule 60 mixes keywords with conflicting directions" suricata.log | wc -l | xargs
expect: 1
Loading