detect: backport tests for file.data to 7 #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
changed the title
catenacyber
force-pushed
the
detect-file-data-close-7577-backport7
branch
from
2e0eb0f to
3535152
Compare
Ticket: 7577
catenacyber
force-pushed
the
detect-file-data-close-7577-backport7
branch
from
3535152 to
dd36d08
Compare
catenacyber
commented
Mar 6, 2025
| @@ -16,26 +16,32 @@ checks: | |||
| event_type: alert | |||
| alert.signature_id: 2 | |||
| - filter: | |||
| # Suricata 7 does not manage to decode the second file (its size is 0) | |||
There was a problem hiding this comment.
I think this other bug got fixed by moving mime parsing to rust in 8...
There was a problem hiding this comment.
do we need to fix that in 7?
There was a problem hiding this comment.
victorjulien
approved these changes
Mar 6, 2025
|
Merged in #2340, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7577
Backport of #2333