detect: fix possible leak found by coverity

Conditions to create the leak are likely not reachable, but this is still a bad pattern.
OISF · Jan 21, 2022 · e806099 · e806099
1 parent cc746b4
commit e806099
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/detect-engine-port.c b/src/detect-engine-port.c
@@ -213,8 +213,12 @@ int DetectPortInsert(DetectEngineCtx *de_ctx, DetectPort **head,
                     goto error;
 
                 r = DetectPortInsert(de_ctx, head, new);
-                if (r == -1)
+                if (r == -1) {
+                    if (c != NULL) {
+                        DetectPortFree(de_ctx, c);
+                    }
                     goto error;
+                }
 
                 if (c != NULL) {
                     SCLogDebug("inserting C (%p)", c);